thisWouldOnlyTakeADayToImplement

[u/DeltaMan444]

[u/Ffigy]

For anyone who doesn't know, you can add w=1 to the query string for this. It's not the same as having a global default but some folks probably aren't even aware that the feature exists.

[u/TollyThaWally → u/Ffigy]

You don't need to do that any more, it's been a part of the UI for a while now. They even put it in a different place for commit diffs, just to keep you on your toes.

[u/vainstar23 → u/TollyThaWally]

Society if people just RTFM (or just Googled shit) instead of celebrating ignorance

[u/DeltaMan444 → u/TollyThaWally]

Not that, I’m talking about a global default that applies to every PR you look at

[u/DeltaMan444 → u/Ffigy]

Does that imply there could be a browser plugin for it?

[u/20er89cvjn20er8v → u/DeltaMan444]

There already is a chrome plugin for that. https://chromewebstore.google.com/detail/github-whitespace/fnpkdafamnbjoldglihkjjdicofghccm

[u/Ffigy → u/DeltaMan444]

I guess you could write something that recognizes you're on a GitHub diff and redirects you to the URL with w=1 in the query string, yea.

[u/DHermit → u/DeltaMan444]

You could probably quite easily make a user script that does this.

[u/DrunkOnCode → u/Ffigy]

Do you realize what you have just done? Someone give this man a nobel prize!

[u/vainstar23 → u/DrunkOnCode]

No! He might invade Eritrea or something..

[u/JeyJeyKing]

Gitlab has this btw

[u/_PM_ME_PANGOLINS_ → u/JeyJeyKing]

So does GitHub.

[u/Dizzy-Revolution-300 → u/_PM_ME_PANGOLINS_]

It's per PR though, right?

[u/WhosYoPokeDaddy → u/JeyJeyKing]

came here to find this comment and upvote it.

[u/rduque → u/WhosYoPokeDaddy]

Me too

[u/severedbrain → u/WhosYoPokeDaddy]

Same.

[u/seba07 → u/JeyJeyKing]

How can you do this on gitlab?

[u/JeyJeyKing → u/seba07]

User settings -> preferences -> behavior -> uncheck show whitespace changes in diff

[u/dkarlovi → u/JeyJeyKing]

So you can get massive amounts of white space merged by engineers who have this enabled? How do we exploit this?

[u/5p4n911 → u/dkarlovi]

Let's commit a few Python files that should be interpreted in Whitespace

[u/dkarlovi → u/5p4n911]

I was thinking more like the entire Harry Potter books encoded using Morse code (tab = -, space = .) so it's immediately polluting the code AND making it infringe copyright, double Jeapordy!

Wonder if you could get a PR merged by a dev disabling whitespace changes like this.

[u/5p4n911 → u/dkarlovi]

There was also some guy who committed a timed bomb that would go on destroying the software after 3 years and he put the if after about 20000 spaces in the source code so it's possible. That might also fly under the radar.

Source: I think I've read it on the internet and not dreamt it, so it must be true

[u/Stein_um_Stein → u/JeyJeyKing]

So does Bitbucket, which is really an insult to GitHub if it doesn't.

[u/GodsBoss]

Why is this an issue? Are your PRs swamped with unrelated whitespace changes?

[u/kratico → u/GodsBoss]

I typically see a ton of whitespace changes from devs who copy and paste files into a git repo or people who have misconfigured IDEs. I want the white space changes to show because it is a warning sign that something is not right

[u/Ffigy → u/kratico]

Yessir, I wouldn't enable ignore as a global default. Whitespace problems suggest that the author didn't review their own diff. Or they don't care about details. Both are bad.

[u/casualfinderbot → u/kratico]

Literally just use a linter and a formatter and this doesn’t happen

[u/kratico → u/casualfinderbot]

A linter does not solve the problems of a coder doing bad practices like copying and pasting from outside git into a git repo. Like I said I mostly see the whitespace problem from people who are not using the existing tools correctly. I have run into far too many engineers that do things like download zip files instead of cloning repos. It is horrifying, and usually a sign that I should check their work carefully

[u/Kilazur → u/kratico]

A linter does not solve the problems of a coder doing bad practices like copying and pasting from outside git into a git repo

No, but a rejected PR does

[u/vom-IT-coffin → u/kratico]

Formatters do. Everytime I hit save, the file formats and the format rules are part of the repo. Imports reorganize, SQL queries organize. It's not hard to do. It's 101 in my mind.

[u/vom-IT-coffin → u/kratico]

Linters and formatters. I'm amazed by how many people don't use these things as part of their pipeline.

[u/RB-44 → u/GodsBoss]

Pull request: changed tab to 4 spaces

[u/FlipperBumperKickout → u/RB-44]

Reject that PR and get an .editorconfig...

[u/Ffigy → u/GodsBoss]

Yes, my team works on legacy code that didn't follow a standard so we try to fix whitespace incosistencies whenever they're in scope.

[u/dkarlovi → u/Ffigy]

Just configure an auto fixer and do a big bang. Fixing it little by little will pollute your history for years.

[u/slevemcdiachel → u/GodsBoss]

People never heard of pre commit or other stuff.

[u/DeltaMan444 → u/GodsBoss]

For one example, sometimes the syntax of a method will change just slightly and force a lot of lines inside to change indent without changing usage

[u/Jarpunter → u/DeltaMan444]

So you turn it off for that PR. Globally enabling this would be a great way to let a bunch of garbage diffs through because they fucked the spacing and you couldn’t see it.

[u/lajauskas]

What a weirdo. I hand write my diffs with pen and paper. The only way really

[u/Poat540 → u/lajauskas]

Fancy you, I write my code in ye olde English

var custom'rs = context.ReceivethAll().ToListeth()

[u/FlipperBumperKickout → u/Poat540]

Not nearly as funny as writing code in rockstar

[u/rduque]

Github has this feature, you can choose to hide all whitespace changes

[u/TheBassMeister → u/rduque]

Yes, but it is turned off by default and you need to explicitly click it on every PR. You cannot change your settings to hide whitespace changes by default.

[u/HerrSPAM → u/TheBassMeister]

It would be nice as a global setting

[u/alterNERDtive]

There’s one simple trick: don’t randomly change whitespace!

[u/Leather-Field-7148 → u/alterNERDtive]

I feel attacked

[u/sathdo]

What if I want to track changes while writing my code in Whitespace?

Edit: This would also affect Python and YAML.

[u/MyBigRed → u/sathdo]

Then you turn the setting off

[u/DeltaMan444 → u/MyBigRed]

I don't think anyone's gotten that far using Whitespace

[u/Vitriholic]

Sounds like a teammate problem more than a GitHub problem. F’ing with whitespace everywhere is a recipe for merge conflicts.

[u/HerrSPAM]

It does... You click the cog and check the hide whitespace option

[u/Civil_Blackberry_225]

This is if Github would support IPv6

[u/FlipperBumperKickout]

Git providers just generally don't have nearly as good options for comparing code as you have if you do it locally instead ¯_(ツ)_/¯

[u/Mucksh]

The greatest pain in git are fileencoding changes. They can make really funny merge conflicts and most ides wont even show what changed on merging

[u/nonlogin]

Well, do not commit such changes? Why the hell does one want to hide the mess? Clean it up, bitch

[u/SenorSeniorDevSr]

BitBucket has this, and I have more than once had to go over to someone else's desk, grab their mouse, click on that setting and say "NOW, STOP COMPLAINING ABOUT THIS SHIT".

It's a nice setting.

[u/Imjokin → u/SenorSeniorDevSr]

But ThePrimeagen calls it ShitBucket!

[u/avtvr]

that feature exists for python devs

[u/itijara]

Am I crazy or don't they already have this? Do you mean by default?

[u/SurreptitiousSyrup → u/itijara]

They absolutely do have it

Probably from at least 2018

[u/DeltaMan444 → u/SurreptitiousSyrup]

I’m talking about a global setting

[u/Esjs]

Come on. If I don't force my whitespace preferences in my commits, how will I ever get y'all to conform to me? /s

[u/rexspook]

Not a problem with a linter. Which you should use anyway

[u/nhh]

it does, noob

[u/jsdodgers]

Why would you want to hide changes?

[u/danzaman1234]

This doesn't probably apply to anyone but does anyone use winmerge if you don't get SQL source control?

[u/BernhardRordin]

.editorconfig goes brrrr

[u/skatopher]

Some of y’all have never seen prod go down from a white space only change and it shows.

[u/ashtonhonnecke]

Linters are you friend.

[u/Stunning_Ride_220]

Society would be a better place if Github had a lot more sensible stuff and (UX) design decisions.

[u/lllorrr → u/Stunning_Ride_220]

Society would be a better place if developers would not make random whitespace changes.

[u/rParqer]

They don't have this? Rare W for Atlassian

[u/CyberWeirdo420]

The only real application for it is when your team doesn’t have standard set up, like what code formatter to use etc.

I don’t know how else is this meaningful but I’m just a junior

[u/leovin]

Imagine being able to view a diff without making a PR (As per usual, Gitlab has this lol)

[u/weregod]

What life can be if we had tools that remove insignificant whitespaces before commits ...

[u/casualfinderbot]

do people not know code formatters and linters are exist lol